Swift 3.1 - update APIs to resolve LoopKit 1.2.0 deprecation warnings#425
Closed
bharat wants to merge 8 commits intoLoopKit:devfrom
Closed
Swift 3.1 - update APIs to resolve LoopKit 1.2.0 deprecation warnings#425bharat wants to merge 8 commits intoLoopKit:devfrom
bharat wants to merge 8 commits intoLoopKit:devfrom
Conversation
added 6 commits
March 29, 2017 17:57
1. Change all explicit calls to .debugDescription over to String(describing:). This preserves existing behavior which was happening implicitly before swift 3.1 2. Use CGFloat.pi instead of CGFloat(Double.pi), and fix an issue where I accidentally negated one of the values in an earlier commit
Separate them out from the non-API related warning fixes.
This was referenced Mar 30, 2017
bharat
changed the title
bharat
changed the title
We were accidentally getting 1.2.1 because carthage considers it to be compatible when you use the ~> notation.
ps2
pushed a commit
that referenced
this pull request
Jul 17, 2021
ps2
pushed a commit
that referenced
this pull request
Jul 17, 2021
…warning (#425) Merge from release/v1.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #421